Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stereo button is shown for non-vr content #313

Merged
merged 1 commit into from
Dec 9, 2018
Merged

fix: stereo button is shown for non-vr content #313

merged 1 commit into from
Dec 9, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Dec 9, 2018 •
edited

Description of the Changes

add props.state.engine.isVr condition

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Dec 9, 2018
@yairans yairans requested a review from dan-ziv December 9, 2018 13:35
@yairans yairans changed the title fix: vr button is shown for non vr content fix: stereo button is shown for non vr content Dec 9, 2018
@yairans yairans changed the title fix: stereo button is shown for non vr content fix: stereo button is shown for non-vr content Dec 9, 2018
@yairans yairans merged commit 48a4132 into master Dec 9, 2018
@yairans yairans deleted the fix-vr-button branch December 9, 2018 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-ziv dan-ziv dan-ziv approved these changes

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yairans @dan-ziv