Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: uncaught exception from playlist countdown component #314

Merged
merged 1 commit into from
Dec 11, 2018
Merged

fix: uncaught exception from playlist countdown component #314

merged 1 commit into from
Dec 11, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Dec 11, 2018 •
edited

Description of the Changes

add next existence protection

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Dec 11, 2018
@yairans yairans requested a review from a team December 11, 2018 08:29
@yairans yairans merged commit ec71046 into master Dec 11, 2018
@yairans yairans deleted the null-next branch December 11, 2018 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yairans @OrenMe