Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-8775): preplayback is not updated if play is requested before media is loaded #318

Merged
merged 1 commit into from
Dec 19, 2018

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Dec 19, 2018

Description of the Changes

if play is called on API of player before loadMedia ends then in player we cache the play and when engine loads we start playing.
In UI we set the prePlayback state on the source selected and it might come after the play and case the prePlayback state to be invalid.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@OrenMe OrenMe self-assigned this Dec 19, 2018
@OrenMe OrenMe merged commit a7d2bb8 into master Dec 19, 2018
@OrenMe OrenMe deleted the FEC-8775 branch December 19, 2018 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant