Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8781): simplify center ui elements #321

Merged
merged 2 commits into from
Dec 31, 2018
Merged

fix(FEC-8781): simplify center ui elements #321

merged 2 commits into from
Dec 31, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Dec 24, 2018 •
edited

Description of the Changes

use transform: translate(-50%, -50%) to center an element

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from a team December 24, 2018 11:54
@yairans yairans self-assigned this Dec 24, 2018
@yairans yairans merged commit e6acda4 into master Dec 31, 2018
@yairans yairans deleted the FEC-8781 branch December 31, 2018 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-ziv dan-ziv dan-ziv approved these changes

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yairans @dan-ziv