fix(FEC-8258): captions and audio 'for' attribute is set to 'quality' #328

odedhutzler · 2019-01-10T12:07:38Z

Changed the attribute to match the current label (the one in props), instead of 'icon.quality'

changes have been done against master branch, and PR does not conflict
new unit / functional tests have been added (whenever applicable)
test are passing in local environment
Travis tests are passing (or test results are not worse than on master branch :))
Docs have been updated

src/components/smart-container/smart-container-item.js

changed to label to suit the realy one, instead of 'quality'

bf84353

odedhutzler added the Priority: Low label Jan 10, 2019

odedhutzler self-assigned this Jan 10, 2019

odedhutzler requested a review from a team January 10, 2019 12:07

remove unused var

d0f85ff

odedhutzler commented Jan 14, 2019

View reviewed changes

src/components/smart-container/smart-container-item.js Show resolved Hide resolved

odedhutzler added 2 commits January 14, 2019 16:32

Merge branch 'master' of https://github.com/kaltura/playkit-js-ui into …

10eabff

…FEC-8258

add name attribute to the dropdown

0ac618f

OrenMe approved these changes Jan 14, 2019

View reviewed changes

odedhutzler merged commit 26ea92b into master Jan 14, 2019

odedhutzler deleted the FEC-8258 branch January 14, 2019 15:14

Provide feedback