Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-8124): render player ads UI (also on mobile) unless configured else #334

Merged
merged 3 commits into from
Jan 22, 2019
Merged

feat(FEC-8124): render player ads UI (also on mobile) unless configured else #334

merged 3 commits into from
Jan 22, 2019

Conversation

odedhutzler
Copy link
Contributor

@odedhutzler odedhutzler commented Jan 21, 2019 •
edited

Render the default player view also on mobile
Added click-through css so the clicks will propagate to IMA

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@odedhutzler
we will render the default player view also on mobile
5cbbc28 
added click-through css so the clicks will propogate to IMA
@odedhutzler odedhutzler self-assigned this Jan 21, 2019
@odedhutzler odedhutzler requested a review from a team January 21, 2019 10:34
@odedhutzler odedhutzler merged commit 0dcbb68 into master Jan 22, 2019
@odedhutzler odedhutzler deleted the FEC-8124 branch January 22, 2019 14:31
@odedhutzler odedhutzler mentioned this pull request Feb 20, 2019
Merged
5 tasks
@yairans yairans mentioned this pull request Jul 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@odedhutzler odedhutzler

Labels
Priority: High
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@odedhutzler @OrenMe