fix(FEC-8768): seeking back on ended doesn't work when casting #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @yairans, |
Merged
5 tasks
OrenMe
approved these changes
Jan 30, 2019
yairans
added a commit
to kaltura/playkit-js-cast-sender
that referenced
this pull request
Jan 30, 2019
This reverts commit 9d1c007 Use `CastAfterPlay` component because from kaltura/playkit-js-ui#342 there is no bottom bar when casting is ended
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
BottomBarandTopBarwhen casting and the player is endedCastAfterPlaycomponent for fix(FEC-8768): seeking back on ended doesn't work when casting playkit-js-cast-sender#14This reverts part of commit ae87bc9
TopBarcomponentCheckLists