Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cast ui shows replay button when seeking after replay #343

Merged
merged 6 commits into from
Feb 4, 2019
Merged

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Jan 31, 2019

Description of the Changes

Somehow when BottomBar/TopBar returns undefined it causes duplication of SeekBar creation. So handle casting+ended logic via css style

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Jan 31, 2019
@yairans yairans requested a review from a team January 31, 2019 15:27
@yairans yairans changed the title Fec 8768 fix: cast ui shows replay button when seeking after replay Jan 31, 2019
@kaltura-hooks
Copy link

Hi @yairans,
Thank you for contributing this pull request!
Please sign the Kaltura CLA so we can review and merge your contribution.
Learn more at http://bit.ly/KalturaContrib

@yairans yairans merged commit ac98217 into master Feb 4, 2019
@yairans yairans deleted the FEC-8768 branch February 4, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants