Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-8888): the playback paused when tap on "unmute" button on Android #345

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

odedhutzler
Copy link
Contributor

@odedhutzler odedhutzler commented Feb 5, 2019

Description of the Changes

Stop the event from bubbling to the shell component.
The shell component listens to this event as well, and for some reason the unmute there causes the player to pause.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

The shell component listens to this event as well, and for some reason the unmute there causes the player to pause.
@odedhutzler odedhutzler self-assigned this Feb 5, 2019
@odedhutzler odedhutzler requested a review from a team February 5, 2019 14:30
@odedhutzler odedhutzler merged commit 847eaa9 into master Feb 5, 2019
@odedhutzler odedhutzler deleted the FEC-8888 branch February 5, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants