Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-8868): mobile ads preset #346

Merged
merged 5 commits into from
Feb 20, 2019
Merged

feat(FEC-8868): mobile ads preset #346

merged 5 commits into from
Feb 20, 2019

Conversation

odedhutzler
Copy link
Contributor

@odedhutzler odedhutzler commented Feb 10, 2019

Description of the Changes

Added fullscreen and volume controls to the IMA mobile preset.
moved everything to the left, so it won't clash with IMA's skip button.
Render the default player view also on mobile

References:
#334

unknown

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@odedhutzler odedhutzler self-assigned this Feb 10, 2019
@odedhutzler odedhutzler requested a review from a team February 10, 2019 16:06
@yairans yairans changed the title feat(FEC-8868): mobile IMA preset feat(FEC-8868): mobile ads preset Feb 20, 2019
src/ui-presets/ads.js Show resolved Hide resolved
src/components/bottom-bar/_bottom-bar.scss Show resolved Hide resolved
src/ui-presets/ads.js Outdated Show resolved Hide resolved
src/ui-presets/ads.js Show resolved Hide resolved
@odedhutzler odedhutzler merged commit 3726d7d into master Feb 20, 2019
@odedhutzler odedhutzler deleted the FEC-8868 branch February 20, 2019 13:12
odedhutzler added a commit that referenced this pull request Feb 27, 2019
@odedhutzler odedhutzler mentioned this pull request Feb 27, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants