Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-8454): handle small player views #348

Merged
merged 9 commits into from
Feb 27, 2019
Merged

feat(FEC-8454): handle small player views #348

merged 9 commits into from
Feb 27, 2019

Conversation

odedhutzler
Copy link
Contributor

@odedhutzler odedhutzler commented Feb 19, 2019

Description of the Changes

Added 2 more breakpoints to the player view:
TINY: < 280px
EXTRA_SMALL: 380px - 480px

on tiny players - show only the seekbar and the volume (volume bar is not shown as well)
on extra small players - remove the play & seek back buttons and reduce the
margin between the icons

small-players screenshot

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@odedhutzler odedhutzler self-assigned this Feb 19, 2019
@odedhutzler odedhutzler requested a review from a team February 19, 2019 12:15
OrenMe
OrenMe previously approved these changes Feb 27, 2019
@odedhutzler odedhutzler merged commit 2dd65ad into master Feb 27, 2019
@odedhutzler odedhutzler deleted the FEC-8454 branch February 27, 2019 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants