Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8903): when loading a player with display: none, the player size class is set to small #350

Merged
merged 2 commits into from
Feb 20, 2019
Merged

fix(FEC-8903): when loading a player with display: none, the player size class is set to small #350

merged 2 commits into from
Feb 20, 2019

Conversation

odedhutzler
Copy link
Contributor

@odedhutzler odedhutzler commented Feb 20, 2019 •
edited

Description of the Changes

Besides checking for dimension on resize events, check for dimensions on FIRST_PLAY event.

this way, if the player is hidden before (with dispaly: none e.g) it will be rendered with it's real width and height when it is playing.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@odedhutzler odedhutzler self-assigned this Feb 20, 2019
@odedhutzler odedhutzler requested a review from a team February 20, 2019 14:03
yairans
yairans suggested changes Feb 20, 2019
View reviewed changes
src/components/shell/shell.js Outdated Show resolved Hide resolved
@odedhutzler odedhutzler merged commit 20c5c43 into master Feb 20, 2019
@odedhutzler odedhutzler deleted the FEC-8903 branch February 20, 2019 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

Assignees

@odedhutzler odedhutzler

Labels
Priority: Medium
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@odedhutzler @yairans