Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-8294): toggle unmute on volume icon click when volume was decreased to zero via dragging #353

Merged
merged 3 commits into from
Feb 27, 2019
Merged

feat(FEC-8294): toggle unmute on volume icon click when volume was decreased to zero via dragging #353

merged 3 commits into from
Feb 27, 2019

Conversation

odedhutzler
Copy link
Contributor

when the volume is 0, and mute/unmute is clicked - change volume to 0.5t.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@odedhutzler odedhutzler self-assigned this Feb 24, 2019
@odedhutzler odedhutzler requested a review from a team February 24, 2019 08:19
@odedhutzler odedhutzler merged commit 9c391f2 into master Feb 27, 2019
@odedhutzler odedhutzler deleted the FEC-8294 branch February 27, 2019 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@odedhutzler odedhutzler

Labels
Priority: Medium
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@odedhutzler @OrenMe