Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8843): issue while closing the setting menu #366

Merged
merged 2 commits into from
May 6, 2019
Merged

fix(FEC-8843): issue while closing the setting menu #366

merged 2 commits into from
May 6, 2019

Conversation

odedhutzler
Copy link
Contributor

When menus are open - just close the menu.
The click should not play/pause as well.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@odedhutzler
handle click outside when the menu is open
e8b28d4 
when menus are open - just close the menu, dont play/pause as well
@odedhutzler odedhutzler self-assigned this Mar 10, 2019
@odedhutzler odedhutzler requested a review from a team March 10, 2019 15:00
RoyBregman
RoyBregman previously approved these changes May 6, 2019
View reviewed changes
Copy link
Contributor

@RoyBregman RoyBregman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix is correct

@RoyBregman
Merge branch 'master' into FEC-8843
88b541d 
# Conflicts:
#	src/components/overlay-action/overlay-action.js
@RoyBregman RoyBregman merged commit 9820c35 into master May 6, 2019
@RoyBregman RoyBregman deleted the FEC-8843 branch May 6, 2019 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoyBregman RoyBregman RoyBregman approved these changes

Assignees

@odedhutzler odedhutzler

Labels
Priority: Medium
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@odedhutzler @RoyBregman