Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8980): size CSS class is incorrect if player is rendered when detached from DOM #367

Merged
merged 1 commit into from
Mar 17, 2019
Merged

fix(FEC-8980): size CSS class is incorrect if player is rendered when detached from DOM #367

merged 1 commit into from
Mar 17, 2019

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Mar 17, 2019

Description of the Changes

the getBoudingClientRect returns width: 0 and height: 0 in this case, causing incorrect size class

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@OrenMe
fix(FEC-8980): size CSS class is incorrect if player is rendered when…
3c11951 
… detached from DOM

the `getBoudingClientRect` returns width: 0 and height: 0 in this case, causing incorrect size class
@OrenMe OrenMe self-assigned this Mar 17, 2019
@OrenMe OrenMe merged commit 5ad349f into master Mar 17, 2019
@OrenMe OrenMe deleted the FEC-8980 branch March 17, 2019 12:42
@yairans yairans mentioned this pull request Jan 1, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

@odedhutzler odedhutzler odedhutzler approved these changes

Assignees

@OrenMe OrenMe

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OrenMe @yairans @odedhutzler