Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-7642): firefox speed selector keyboard shortcut doesnt work #368

Merged
merged 1 commit into from
Mar 19, 2019
Merged

fix(FEC-7642): firefox speed selector keyboard shortcut doesnt work #368

merged 1 commit into from
Mar 19, 2019

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Mar 19, 2019

Description of the Changes

different key code in firefox for semi colon

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Yuvalke
fix(FEC-7642): firefox speed selector keyboard shortcut doesnt work
3b6c42b 
different key code in firefox for semi colon
@Yuvalke Yuvalke self-assigned this Mar 19, 2019
@Yuvalke Yuvalke requested a review from OrenMe March 19, 2019 10:17
@Yuvalke Yuvalke assigned Yuvalke and unassigned Yuvalke Mar 19, 2019
@Yuvalke Yuvalke merged commit ce9d3b8 into master Mar 19, 2019
@Yuvalke Yuvalke deleted the FEC-7642 branch March 19, 2019 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@Yuvalke Yuvalke

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Yuvalke @OrenMe