Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-9004): share copy link doesn't work on iOS #376

Merged
merged 2 commits into from
Apr 3, 2019
Merged

fix(FEC-9004): share copy link doesn't work on iOS #376

merged 2 commits into from
Apr 3, 2019

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Apr 3, 2019

Description of the Changes

on iOS it is required to use setSelectionRange to select an input.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@OrenMe OrenMe self-assigned this Apr 3, 2019
@OrenMe OrenMe requested a review from yairans April 3, 2019 07:35
@OrenMe OrenMe merged commit 5f0e4d5 into master Apr 3, 2019
@OrenMe OrenMe deleted the FEC-9004 branch April 3, 2019 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

Assignees

@OrenMe OrenMe

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OrenMe @yairans