Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-9005): no tooltip displayed on copy link icon #378

Merged
merged 2 commits into from
Apr 3, 2019
Merged

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Apr 3, 2019

Description of the Changes

Added tooltips and i18n support for copy and email and embed share buttons.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@OrenMe OrenMe self-assigned this Apr 3, 2019
@OrenMe OrenMe requested a review from yairans April 3, 2019 10:28
@@ -18,6 +18,9 @@
"unmute": {
"unmute": "Unmute"
},
"copy": {
"button": "copy"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"button": "copy"
"button": "Copy"

@OrenMe OrenMe requested a review from yairans April 3, 2019 10:44
@OrenMe OrenMe merged commit f7f4f70 into master Apr 3, 2019
@OrenMe OrenMe deleted the FEC-9005 branch April 3, 2019 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants