Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-9011): share button dose not work on end screen #381

Merged
merged 1 commit into from
Apr 4, 2019
Merged

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Apr 3, 2019

Description of the Changes

on end screen the pre playback overlay hides entire video area.
Use same hack as control bar and add z-index: 1
Also added CSS rule to keep button always visible like control bar and not on hover.
I general we need to find something less hacky then z-index dependency between pre-playback overlay and end screen visible controls. will open a separate ticket.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@OrenMe OrenMe self-assigned this Apr 3, 2019
@OrenMe OrenMe requested a review from yairans April 3, 2019 18:21
@OrenMe OrenMe merged commit 93743d3 into master Apr 4, 2019
@OrenMe OrenMe deleted the FEC-9011 branch April 4, 2019 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants