Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-9178): seekbar hide the captions #391

Merged
merged 3 commits into from
Jun 11, 2019
Merged

fix(FEC-9178): seekbar hide the captions #391

merged 3 commits into from
Jun 11, 2019

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Jun 5, 2019

Description of the Changes

add prefix for transform prop on browser which doesn't fully support

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Yuvalke
fix(FEC-9178): seekbar slide up on captions
3e76c12 
add prefix for transform prop on browser which doesn't fully support
@Yuvalke Yuvalke requested review from OrenMe and yairans June 5, 2019 11:45
@Yuvalke Yuvalke self-assigned this Jun 5, 2019
@Yuvalke Yuvalke changed the title fix(FEC-9178): seekbar slide up on captions fix(FEC-9178): seekbar hide the captions Jun 5, 2019
@Yuvalke Yuvalke merged commit 8b4e6d4 into master Jun 11, 2019
@Yuvalke Yuvalke deleted the FEC-9178 branch June 11, 2019 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans Awaiting requested review from yairans

Assignees

@Yuvalke Yuvalke

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Yuvalke @OrenMe