Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-9056): 10-second fast forward button #398

Merged
merged 5 commits into from
Aug 19, 2019
Merged

feat(FEC-9056): 10-second fast forward button #398

merged 5 commits into from
Aug 19, 2019

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Jul 30, 2019 •
edited

Description of the Changes

image

  • add 10-sec FF button and generic FF button for non-10 configured
  • reduce time-display padding to 12px in the MEDIUM player (480px-768px)
  • increase control-button-container margin to 3px in the X-SMALL/SMALL player (280px-480px)

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from a team July 30, 2019 09:54
@yairans yairans self-assigned this Jul 30, 2019
@OrenMe OrenMe merged commit fd23f3b into master Aug 19, 2019
@OrenMe OrenMe deleted the FEC-9056 branch August 19, 2019 06:56
@yairans yairans mentioned this pull request Jun 23, 2020
Merged
5 tasks
yairans added a commit that referenced this pull request Jun 25, 2020
@yairans
fix(FEC-10235): Play/Pause button is not accurately centered in small…
f2f608f 
… player (#519)

Since #398. 
Use `transform: translate(-50%, -50%)` and `white-space: nowrap` insteadof hardcoded `margin`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@yairans yairans

Labels
Priority: High Type: Feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yairans @OrenMe