feat(FEC-9174): customize logo on bottom bar #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrenMe
reviewed
Aug 15, 2019
| */ | ||
| static shouldRender(props: any): boolean { | ||
| const componentConfig = props.config.components[this.displayName]; | ||
| return !(Object.keys(componentConfig).length === 0 && componentConfig.constructor === Object); |
There was a problem hiding this comment.
this is for case that we didn't config this ui element so we don't want to render the element.
I took it actually from watermark and I saw it in other configurable components
There was a problem hiding this comment.
yes, I saw the reference but couldn't make sense of the actual check itself. What does it check for and why like this? you can check with @yairans who created it for the other component.
OrenMe
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
add customize logo from ui config added for small screen and up
CheckLists