feat(FEC-7552): added escape functionality to languages, settings, dropdown and advanced captions settings #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuvalke
previously requested changes
Aug 22, 2019
OrenMe
requested changes
Aug 25, 2019
we still don't have a good way to focus on the secondary dropdown element
OrenMe
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added esc listeners to languages and settings.
In dropdowns - after list is closed focus back on button
In CVAA - added focus to overlay after mount and when switching between advanced and predefined because the esc doesn't work when not focused inside the overlay