Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-9351): cast button is not visible #411

Merged
merged 1 commit into from
Sep 22, 2019
Merged

fix(FEC-9351): cast button is not visible #411

merged 1 commit into from
Sep 22, 2019

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Sep 22, 2019

Description of the Changes

-- directive in Sass doesn't evaluate the variable unless it is explicitly set with hash

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@OrenMe
fix(FEC-9351): cast button is not visible
f494f78 
`--` directive in Sass doesn't evaluate the variable unless it is explicitly set with hash
@OrenMe OrenMe self-assigned this Sep 22, 2019
@OrenMe OrenMe merged commit 708a9f2 into master Sep 22, 2019
@OrenMe OrenMe deleted the FEC-9351 branch September 22, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

@esakal esakal Awaiting requested review from esakal

Assignees

@OrenMe OrenMe

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OrenMe @yairans