Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-9341): learn more isn't clickable on mobile #412

Merged
merged 1 commit into from
Sep 24, 2019
Merged

fix(FEC-9341): learn more isn't clickable on mobile #412

merged 1 commit into from
Sep 24, 2019

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Sep 24, 2019

Description of the Changes

add missing disable on TopBar for ads ui

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Yuvalke
fix: learn more doesn't clickable on mobile
9cf889a 
add missing disable on TopBar for ads ui
@Yuvalke Yuvalke requested a review from OrenMe September 24, 2019 07:49
@Yuvalke Yuvalke self-assigned this Sep 24, 2019
@Yuvalke Yuvalke changed the title fix: learn more doesn't clickable on mobile fix(FEC-9341): learn more doesn't clickable on mobile Sep 24, 2019
@OrenMe OrenMe changed the title fix(FEC-9341): learn more doesn't clickable on mobile fix(FEC-9341): learn more isn't clickable on mobile Sep 24, 2019
@Yuvalke Yuvalke merged commit ccc225b into master Sep 24, 2019
@Yuvalke Yuvalke deleted the fix-top-bar branch September 24, 2019 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@Yuvalke Yuvalke

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Yuvalke @OrenMe