Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ads preset fails when using player #414

Merged
merged 1 commit into from
Sep 25, 2019
Merged

fix: ads preset fails when using player #414

merged 1 commit into from
Sep 25, 2019

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Sep 25, 2019

Description of the Changes

following #410 Ads preset is referencing player directly so need to use context.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@OrenMe OrenMe self-assigned this Sep 25, 2019
@OrenMe OrenMe merged commit 31f2b1c into master Sep 25, 2019
@OrenMe OrenMe deleted the FEC-9341-2 branch September 25, 2019 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yuvalke Yuvalke Yuvalke approved these changes

@yairans yairans Awaiting requested review from yairans

Assignees

@OrenMe OrenMe

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OrenMe @Yuvalke