Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-9391): volume bar doesn't open by pressing on up/down arrows #421

Merged
merged 2 commits into from
Oct 3, 2019
Merged

fix(FEC-9391): volume bar doesn't open by pressing on up/down arrows #421

merged 2 commits into from
Oct 3, 2019

Conversation

RoyBregman
Copy link
Contributor

Description of the Changes

When focused on the volume button - up / down should open the volume bar and control the volume. player was undefined - fixed

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@RoyBregman RoyBregman merged commit 2539697 into master Oct 3, 2019
@RoyBregman RoyBregman deleted the FEC-9391-volume-button branch October 3, 2019 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans Awaiting requested review from yairans

@Yuvalke Yuvalke Awaiting requested review from Yuvalke

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RoyBregman @OrenMe