Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-9399): enter didn't do anything on volume button #424

Merged
merged 6 commits into from
Oct 3, 2019
Merged

fix(FEC-9399): enter didn't do anything on volume button #424

merged 6 commits into from
Oct 3, 2019

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Oct 3, 2019 •
edited

Description of the Changes

add behaviour of toggle mute on keyboard enter.
Implemented onMouseUp cause click on IMA skip button wasn't bubbled to shell.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Yuvalke
fix(FEC-9376): enter event keyboard did do anything
9d315ba 
add behivour of toggle click button on keyboard enter
@Yuvalke Yuvalke requested a review from yairans October 3, 2019 12:34
@Yuvalke Yuvalke self-assigned this Oct 3, 2019
@Yuvalke Yuvalke changed the title fix(FEC-9376): enter didn't do anything fix(FEC-9376): enter didn't do anything on volume button Oct 3, 2019
@Yuvalke Yuvalke changed the title fix(FEC-9376): enter didn't do anything on volume button fix(FEC-9399): enter didn't do anything on volume button Oct 3, 2019
@Yuvalke Yuvalke merged commit a89e5d6 into master Oct 3, 2019
@Yuvalke Yuvalke deleted the FEC-9376-1 branch October 3, 2019 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoyBregman RoyBregman RoyBregman approved these changes

@yairans yairans Awaiting requested review from yairans

Assignees

@Yuvalke Yuvalke

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Yuvalke @RoyBregman