Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-9409): portal doesn't close in ie11 #430

Merged
merged 1 commit into from
Oct 6, 2019
Merged

fix(FEC-9409): portal doesn't close in ie11 #430

merged 1 commit into from
Oct 6, 2019

Conversation

RoyBregman
Copy link
Contributor

Description of the Changes

This was fixed already in FEC-7312 but removed because it looked unneeded - added a comment to make sure it will not be removed again by mistake

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@RoyBregman RoyBregman merged commit b2b156b into master Oct 6, 2019
@RoyBregman RoyBregman deleted the FEC-9409-portal branch October 6, 2019 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yuvalke Yuvalke Yuvalke approved these changes

@OrenMe OrenMe Awaiting requested review from OrenMe

@yairans yairans Awaiting requested review from yairans

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RoyBregman @Yuvalke