Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-9411): accessibility leftovers #431

Merged
merged 19 commits into from
Oct 31, 2019
Merged

feat(FEC-9411): accessibility leftovers #431

merged 19 commits into from
Oct 31, 2019

Conversation

RoyBregman
Copy link
Contributor

@RoyBregman RoyBregman commented Oct 7, 2019 •
edited

Description of the Changes

  1. Added modal mode to Pop keyboard a11y hoc
  2. Refactored code in CVAA overlay
  3. complete a11y of share window
  4. complete a11y of portal mode
  5. extracted small size player calc to shell.js
  6. removed cursor:pointer from custom captions example (as it is not clickable)

Solved in FEC-9411

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@RoyBregman
Copy link
Contributor Author

check casting ui a11y

yairans
yairans previously approved these changes Oct 31, 2019
View reviewed changes
@yairans yairans self-requested a review October 31, 2019 13:05
@RoyBregman RoyBregman merged commit 86cb923 into master Oct 31, 2019
@RoyBregman RoyBregman deleted the FEC-9411-accessibility-leftovers branch October 31, 2019 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

@OrenMe OrenMe Awaiting requested review from OrenMe

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RoyBregman @yairans