Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-9413): when seeking the end of the 2nd entry the playlist skip the 3rd entry (last) and jumps to 1st #432

Merged
merged 1 commit into from
Oct 7, 2019
Merged

fix(FEC-9413): when seeking the end of the 2nd entry the playlist skip the 3rd entry (last) and jumps to 1st #432

merged 1 commit into from
Oct 7, 2019

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Oct 7, 2019 •
edited

Description of the Changes

Do not update the component by props.currentTime if it already updated by props.isPlaybackEnded

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from OrenMe October 7, 2019 18:31
@yairans yairans self-assigned this Oct 7, 2019
@yairans yairans merged commit 138401a into master Oct 7, 2019
@yairans yairans deleted the FEC-9413 branch October 7, 2019 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe Awaiting requested review from OrenMe

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@yairans