Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-9333): when playing a playlist and closing the countdown window, the next entry starts automatically #433

Merged
merged 12 commits into from
Oct 10, 2019
Merged

fix(FEC-9333): when playing a playlist and closing the countdown window, the next entry starts automatically #433

merged 12 commits into from
Oct 10, 2019

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Oct 8, 2019 •
edited

Description of the Changes

  • do not reset the countdown cancel when the postroll is done
  • ignore snapback seeking (from dai)

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans
fix(FEC-9395): playlist countdown works even showing is false
1e23657
@yairans
Merge branch 'master' of https://github.com/kaltura/playkit-js-ui into …
adea062 
…FEC-9381
@yairans
Merge branch 'master' of https://github.com/kaltura/playkit-js-ui into …
f76980f 
…FEC-9333
@yairans
fix(FEC-9333): when playing a playlist and closing the countdown wind…
863abc0 
…ow, the next entry starts automatically
@yairans
update index.js
9c5c8b5
@yairans
fix(FEC-9413): when seeking the end of the 2nd entry the playlist ski…
7ffbe53 
…p the 3rd entry (last) and jumps to 1st
@yairans
fix(FEC-9333): when playing a playlist and closing the countdown wind…
56e8151 
…ow, the next entry starts automatically
@yairans
Merge branch 'FEC-9413' of https://github.com/kaltura/playkit-js-ui i…
ad2bf7b 
…nto FEC-9333
@yairans
remove unrelated fix
fa7b67a
@yairans
Merge branch 'master' into FEC-9333
e35de02
@yairans yairans requested a review from a team October 8, 2019 07:13
@yairans yairans self-assigned this Oct 8, 2019
@yairans yairans merged commit 813d815 into master Oct 10, 2019
@yairans yairans deleted the FEC-9333 branch October 10, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yairans @OrenMe