-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FEC-9282): player support for side panels #434
Conversation
…for unknown reason
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 20 files at r22, 7 of 19 files at r26, 11 of 15 files at r27, 11 of 11 files at r28, 1 of 1 files at r29.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @esakal)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 7 unresolved discussions (waiting on @esakal)
src/components/player-area/player-area.js, line 124 at r29 (raw file):
const {activePresetName, name: playerAreaName} = this.props; if (!playerAreaComponents) {
should be
if (playerAreaComponents.length < 1)
and move to top
src/components/player-area/player-area-provider.js, line 46 at r29 (raw file):
let shouldTriggerListeners = false; (this.props.uiComponents || []).forEach(componentData => { const componentAdded = !!this._addNewComponent(componentData);
whencomponentAdded
false?
src/components/player-area/player-area-provider.js, line 120 at r29 (raw file):
* @private */ _addNewComponent = (componentData, shouldUpdateImmediately) => {
shouldUpdateImmediately
seems like no one pass it
src/components/player-area/player-area-provider.js, line 276 at r29 (raw file):
listen: this._listen, addNewComponent: this._addNewComponentAndUpdateListeners, getAreaComponents: this._getAreaComponents
who is using addNewComponent
and getAreaComponents
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 8 unresolved discussions (waiting on @esakal)
src/components/player-area/player-area.js, line 113 at r29 (raw file):
this.props.logger.debug(`Player area '${playerAreaName}' in preset '${activePresetName}' - register to changes`); this._unregisterListenerCallback = this.context.playerAreaComponentsStore.listen(activePresetName, playerAreaName, this._updateAreaComponents);
better to expose playerAreaComponentsStore.unlisten
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 9 unresolved discussions (waiting on @esakal)
src/components/player-area/player-area-provider.js, line 142 at r29 (raw file):
}); return () => {
better to expose removeComponent
no? maybe need to add id to the components for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 5 files at r30, 1 of 1 files at r32.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @esakal)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r33.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @esakal)
Description of the Changes
Solves FEC-9282
CheckLists
This change is