Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8890): captions menu was not aligned correct in ie11 with bootstrap.css #451

Merged
merged 3 commits into from
Nov 28, 2019
Merged

fix(FEC-8890): captions menu was not aligned correct in ie11 with bootstrap.css #451

merged 3 commits into from
Nov 28, 2019

Conversation

RoyBregman
Copy link
Contributor

@RoyBregman RoyBregman commented Nov 5, 2019 •
edited

Description of the Changes

initial css is not supported in ie11. replaced with 0px

Solves FEC-8890

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

OrenMe
OrenMe reviewed Nov 5, 2019
View reviewed changes
src/styles/_shell.scss Outdated Show resolved Hide resolved
@RoyBregman RoyBregman merged commit 0c6093e into master Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe left review comments

@yairans yairans yairans approved these changes

@Yuvalke Yuvalke Awaiting requested review from Yuvalke

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RoyBregman @OrenMe @yairans