Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-9407): forward button is missing when casting #452

Merged
merged 2 commits into from
Nov 7, 2019
Merged

fix(FEC-9407): forward button is missing when casting #452

merged 2 commits into from
Nov 7, 2019

Conversation

RoyBregman
Copy link
Contributor

Description of the Changes

forwardControl was not exported to be used inside the cast sender

Solves FEC-9407

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

yairans
yairans suggested changes Nov 7, 2019
View reviewed changes
src/components/index.js Outdated Show resolved Hide resolved
@RoyBregman RoyBregman merged commit fc32169 into master Nov 7, 2019
@RoyBregman RoyBregman deleted the FEC-9407-chromecast branch November 7, 2019 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

@OrenMe OrenMe Awaiting requested review from OrenMe

@Yuvalke Yuvalke Awaiting requested review from Yuvalke

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RoyBregman @yairans