Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-9433): timer on seek preview displayed as NaN:NaN:NaN #453

Merged
merged 2 commits into from
Nov 21, 2019

Conversation

RoyBregman
Copy link
Contributor

@RoyBregman RoyBregman commented Nov 12, 2019

Description of the Changes

when dragging scrubber to 0 it fell back to e.changedTouches which was undefined.
Changed the logic to first use e.clientX if is a number (zero included)

Fixes FEC-9433

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@OrenMe
Copy link
Contributor

OrenMe commented Nov 12, 2019

@RoyBregman what happens when you scrub all the way to the end(right side)?

@RoyBregman
Copy link
Contributor Author

@RoyBregman what happens when you scrub all the way to the end(right side)?

It will work as today - The "bug" was only that clientx was ignored when 0 when actually 0 is okay
I rewrote it again with Yair, maybe now it is more readable

@RoyBregman RoyBregman merged commit df3aeba into master Nov 21, 2019
@RoyBregman RoyBregman deleted the FEC-9433-scrubber-NAN branch November 21, 2019 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants