fix(FEC-9505): Add i18n support for custom captions #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuvalke
suggested changes
Dec 1, 2019
| @@ -59,6 +59,7 @@ | |||
| "cvaa": { | |||
| "title": "Advanced captions settings", | |||
| "sample_caption_tag": "Sample", | |||
| "sample_custom_caption_tag": "Custom captions", | |||
There was a problem hiding this comment.
I think you need to keep the format of - "first_second": "First second", I mean to remove the sample
There was a problem hiding this comment.
The reason i left the "sample" was that this is also a sample that shows how the captions look like.
OrenMe
approved these changes
Dec 1, 2019
Yuvalke
approved these changes
Dec 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
replaced span with text tag and id of new localization
solves FEC-9505
CheckLists