Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-7804): implement tooltips #468

Merged
merged 24 commits into from
Jan 2, 2020
Merged

feat(FEC-7804): implement tooltips #468

merged 24 commits into from
Jan 2, 2020

Conversation

RoyBregman
Copy link
Contributor

@RoyBregman RoyBregman commented Dec 18, 2019

Description of the Changes

Implemented tooltip support -

  • contains 8 types of tooltips (default top)
  • boundary check and fallback to other types in case of invalid type
  • multiline and max-width support (default 240px. none will make it one line)
  • next and prev tooltips will not be shown in case the poster preview is shown
  • added debounce util to limit a burst of function calls

Solves (FEC-7804)

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@RoyBregman RoyBregman requested review from Yuvalke, yairans and OrenMe and removed request for yairans and Yuvalke December 25, 2019 14:34
@RoyBregman RoyBregman marked this pull request as ready for review December 25, 2019 16:41
src/components/cast/cast.js Show resolved Hide resolved
src/components/play-pause/play-pause.js Outdated Show resolved Hide resolved
src/components/settings/settings.js Outdated Show resolved Hide resolved
src/components/tooltip/tooltip.js Outdated Show resolved Hide resolved
src/components/tooltip/tooltip.js Outdated Show resolved Hide resolved
src/components/tooltip/_tooltip.scss Show resolved Hide resolved
src/components/tooltip/tooltip.js Show resolved Hide resolved
src/components/tooltip/tooltip.js Outdated Show resolved Hide resolved
src/components/tooltip/tooltip.js Outdated Show resolved Hide resolved
src/components/tooltip/_tooltip.scss Outdated Show resolved Hide resolved
src/components/tooltip/tooltip.js Outdated Show resolved Hide resolved
src/components/tooltip/tooltip.js Outdated Show resolved Hide resolved
src/components/tooltip/tooltip.js Outdated Show resolved Hide resolved
src/components/tooltip/tooltip.js Outdated Show resolved Hide resolved
src/components/shell/shell.js Outdated Show resolved Hide resolved
src/components/tooltip/tooltip.js Outdated Show resolved Hide resolved
src/components/shell/shell.js Outdated Show resolved Hide resolved
Yuvalke
Yuvalke previously requested changes Jan 1, 2020
src/components/tooltip/tooltip.js Outdated Show resolved Hide resolved
src/components/shell/shell.js Outdated Show resolved Hide resolved
src/components/tooltip/tooltip.js Show resolved Hide resolved
OrenMe
OrenMe previously requested changes Jan 1, 2020
src/components/tooltip/tooltip.js Outdated Show resolved Hide resolved
yairans
yairans previously approved these changes Jan 2, 2020
@RoyBregman RoyBregman dismissed stale reviews from OrenMe and Yuvalke January 2, 2020 10:45

done

@RoyBregman RoyBregman merged commit 1180ad1 into master Jan 2, 2020
@RoyBregman RoyBregman deleted the FEC-7804-tooltips branch January 2, 2020 10:46
@OrenMe OrenMe mentioned this pull request Jun 7, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants