Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fullscreen doesn't response correctly #473

Merged
merged 2 commits into from
Jan 2, 2020
Merged

fix: fullscreen doesn't response correctly #473

merged 2 commits into from
Jan 2, 2020

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Jan 2, 2020

Description of the Changes

missing execute function.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Yuvalke Yuvalke self-assigned this Jan 2, 2020
@Yuvalke Yuvalke merged commit 8bee15d into master Jan 2, 2020
@Yuvalke Yuvalke deleted the fullscreen-fix branch January 2, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoyBregman RoyBregman RoyBregman approved these changes

@yairans yairans Awaiting requested review from yairans

Assignees

@Yuvalke Yuvalke

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Yuvalke @RoyBregman