Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-9604): some texts were hard coded and not from localization json #479

Merged
merged 2 commits into from
Jan 29, 2020

Conversation

RoyBregman
Copy link
Contributor

Description of the Changes

Inspired by this PR - #417

seek bar aria label is hard coded
normal speed text in settings is hard coded
volume - typo in aria-valuemax (is written now aria-valuemaz by mistake)

solves FEC-9604

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@RoyBregman RoyBregman merged commit c6e4380 into master Jan 29, 2020
@RoyBregman RoyBregman deleted the FEC-9604-localizations branch January 29, 2020 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants