Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-9634): cast button messes bottom bar #482

Merged
merged 1 commit into from
Feb 3, 2020
Merged

fix(FEC-9634): cast button messes bottom bar #482

merged 1 commit into from
Feb 3, 2020

Conversation

RoyBregman
Copy link
Contributor

Description of the Changes

tooltip tag was wrapping the entire button div instead of just the icon inside

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@RoyBregman RoyBregman merged commit c813674 into master Feb 3, 2020
@RoyBregman RoyBregman deleted the FEC-9634-tooltip-chromecast branch February 3, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RoyBregman @yairans