Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-9601): when pressing key enter on play button there is no exit from fallback state #486

Merged
merged 2 commits into from
Feb 18, 2020
Merged

fix(FEC-9601): when pressing key enter on play button there is no exit from fallback state #486

merged 2 commits into from
Feb 18, 2020

Conversation

RoyBregman
Copy link
Contributor

@RoyBregman RoyBregman commented Feb 18, 2020 •
edited

Description of the Changes

caused by the fix done in FEC-9376.

onClick was changed to mouseup. “Enter” or “Space” on Button elements trigger onClick and therefore now don’t effect the unmute. added handling in key down

solves FEC-9601

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@RoyBregman RoyBregman merged commit 4cf6ab9 into master Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RoyBregman @OrenMe