Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-9657): 'Auto' quality option is hardcoded and not translatable #492

Merged
merged 2 commits into from
Mar 4, 2020
Merged

fix(FEC-9657): 'Auto' quality option is hardcoded and not translatable #492

merged 2 commits into from
Mar 4, 2020

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Mar 3, 2020 •
edited

Description of the Changes

add Auto to en.i18n.json and de.i18n.json

Solves FEC-9657

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from a team March 3, 2020 15:44
@yairans yairans self-assigned this Mar 3, 2020
OrenMe
OrenMe previously approved these changes Mar 3, 2020
View reviewed changes
@yairans yairans merged commit 7eb8c5a into master Mar 4, 2020
@yairans yairans deleted the FEC-9657 branch March 4, 2020 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@yairans yairans

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yairans @OrenMe