Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-7969): when there is an http error in IE11, the error page is not displaying session ID #493

Merged
merged 4 commits into from
Mar 4, 2020
Merged

fix(FEC-7969): when there is an http error in IE11, the error page is not displaying session ID #493

merged 4 commits into from
Mar 4, 2020

Conversation

RoyBregman
Copy link
Contributor

@RoyBregman RoyBregman commented Mar 4, 2020 •
edited

Description of the Changes

The css combination on the session div on ie11 caused it to be not visibile.
Fixed as recommended here - https://makandracards.com/makandra/54644-do-not-use-flex-1-or-flex-basis-0-inside-flex-direction-column-when-you-need-to-support-ie11
Solves FEC-7969

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@RoyBregman RoyBregman merged commit d3a08a3 into master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans yairans approved these changes

@Yuvalke Yuvalke Awaiting requested review from Yuvalke

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RoyBregman @OrenMe @yairans