fix(FEC-9980): custom preset controls are continuously blinking on hovering the bottom bar #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vering the bottom bar
Yuvalke
suggested changes
Apr 20, 2020
src/components/shell/shell.js
Outdated
| @@ -412,7 +412,6 @@ class Shell extends Component { | |||
| className={playerClasses} | |||
| onTouchEnd={e => this.onTouchEnd(e)} | |||
| onMouseUp={() => this.onMouseUp()} | |||
| onMouseOver={() => this.onMouseOver()} | |||
There was a problem hiding this comment.
delete the handler on onMouseOver
Yuvalke
suggested changes
Apr 20, 2020
src/components/shell/shell.js
Outdated
| @@ -412,7 +412,6 @@ class Shell extends Component { | |||
| className={playerClasses} | |||
| onTouchEnd={e => this.onTouchEnd(e)} | |||
| onMouseUp={() => this.onMouseUp()} | |||
| onMouseOver={() => this.onMouseOver()} | |||
| onMouseMove={() => this.onMouseMove()} | |||
There was a problem hiding this comment.
mouse move doesn't handle nav state, it means on keyboard nav it'll stay open -> it handled on onMouseOver
Yuvalke
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Problem: Once the hovering timeout is done the shell is updating the store with
playerHover:falsewhich causes a renderer, but at this time the mouse is still hovering the shell so inonMouseOverthe shell is updating the store withplayerHover:true, and so on for ever...(This reproduce in the preact version 8.x (current) only when custom preset is set, but in preactX even with our default presets)
Solution: remove the state updating from
onMouseOveras it's redundant sinceonMouseMoveSolves: FEC-9980
CheckLists