Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-10071): ad preset is missing the font family #508

Merged
merged 1 commit into from
May 17, 2020
Merged

fix(FEC-10071): ad preset is missing the font family #508

merged 1 commit into from
May 17, 2020

Conversation

yairans
Copy link
Contributor

@yairans yairans commented May 17, 2020 •
edited

Description of the Changes

add the font-family to ad-gui-wrapper class (like playback-gui-wrapper has).

Solves FEC-10071

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from a team May 17, 2020 10:21
@yairans yairans self-assigned this May 17, 2020
@yairans yairans merged commit 893aad5 into master May 17, 2020
@yairans yairans deleted the FEC-10071 branch May 17, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@yairans yairans

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yairans @OrenMe