Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-10121): google translate duplicate texts with Preact #510

Merged
merged 2 commits into from
May 28, 2020
Merged

fix(FEC-10121): google translate duplicate texts with Preact #510

merged 2 commits into from
May 28, 2020

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented May 27, 2020

Description of the Changes

don't translate our player

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Yuvalke Yuvalke requested a review from a team May 27, 2020 08:22
@Yuvalke Yuvalke self-assigned this May 27, 2020
@Yuvalke Yuvalke merged commit 7057e62 into master May 28, 2020
@Yuvalke Yuvalke deleted the FEC-10121 branch May 28, 2020 08:06
@OrenMe OrenMe mentioned this pull request Jun 7, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@Yuvalke Yuvalke

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Yuvalke @OrenMe