Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-9972): floating player #515

Merged
merged 2 commits into from
Jul 2, 2020
Merged

feat(FEC-9972): floating player #515

merged 2 commits into from
Jul 2, 2020

Conversation

RoyBregman
Copy link
Contributor

@RoyBregman RoyBregman commented Jun 8, 2020 •
edited by yairans

Description of the Changes

Exposing KeyMap to be able to check "Enter" in the visibility dismiss button
Solves FEC-9972

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

This change is Reviewable

@RoyBregman RoyBregman requested a review from OrenMe June 8, 2020 11:15
@RoyBregman RoyBregman requested a review from Yuvalke June 8, 2020 11:16
@RoyBregman RoyBregman assigned RoyBregman and unassigned yairans and Yuvalke Jun 8, 2020
@RoyBregman RoyBregman requested a review from yairans June 8, 2020 11:16
@RoyBregman RoyBregman merged commit 258df2d into master Jul 2, 2020
@RoyBregman RoyBregman deleted the FEC-9972-floating-player branch July 2, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yuvalke Yuvalke Yuvalke approved these changes

@OrenMe OrenMe Awaiting requested review from OrenMe

@yairans yairans Awaiting requested review from yairans

Assignees

@RoyBregman RoyBregman

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RoyBregman @Yuvalke @yairans