Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add preset and gui area to all presets #516

Merged
merged 1 commit into from
Jun 18, 2020
Merged

fix: add preset and gui area to all presets #516

merged 1 commit into from
Jun 18, 2020

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Jun 18, 2020 •
edited

Description of the Changes

  • Add preset and gui area to all presets
  • Support manipulate components (before, after and replace) under Fragment
  • Expose the side panel enums

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested review from esakal and OrenMe June 18, 2020 14:31
@yairans yairans closed this Jun 18, 2020
@yairans yairans reopened this Jun 18, 2020
@yairans yairans merged commit 363ce25 into master Jun 18, 2020
@yairans yairans deleted the fix-presets branch June 18, 2020 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@esakal esakal Awaiting requested review from esakal

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yairans @OrenMe