fix(FEC-10227): advanced captions setting window cut when opened in floating player #517
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Issue: When the player is small (<=
480px
), both language menu and cvaa are opened as an overlay in theoverlay-portal
. This causes 2 issues:overlay.position: relative
is inappropriate (pushes the bottom side panel up)componentDidUnmount
of the language menu is running aftercomponentDidMount
of the cvaa, and removing a necessary player class (overlay-active
. sooverlay-portal.pointer-event
remainsnone
)Solution:
overlay.position: absolute
componentDidMount
by timeoutCheckLists