Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-10227): advanced captions setting window cut when opened in floating player #517

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Jun 22, 2020

Description of the Changes

Issue: When the player is small (<= 480px), both language menu and cvaa are opened as an overlay in the overlay-portal. This causes 2 issues:

  1. overlay.position: relative is inappropriate (pushes the bottom side panel up)
  2. componentDidUnmount of the language menu is running after componentDidMount of the cvaa, and removing a necessary player class (overlay-active. sooverlay-portal.pointer-event remains none)

Solution:

  1. change to overlay.position: absolute
  2. delay the componentDidMount by timeout

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from a team June 22, 2020 11:58
@yairans yairans self-assigned this Jun 22, 2020
@yairans yairans merged commit b01a2ea into master Jun 22, 2020
@yairans yairans deleted the FEC-10227 branch June 22, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants